Polyfill.io has been flagged as a server malware. #3711
+7
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supply chain attack noticed in over 100,000 websites using polyfill.io. Replaced with a safer alternative (polyfill-fastly.io)
javascript-translate-bot
added
the
review needed
|
Same here, and more informations: polyfill.io has been proven to be evil as it recently started implanting malicious scripts to jump to gambling sites. |
FloffyGarlic
reviewed
Jul 8, 2024
| @@ -33,7 +32,7 @@ A transpiler would analyze our code and rewrite `height ?? 100` into `(height != | |||
| height = height ?? 100; | |||
|
|
|||
| // after running the transpiler | |||
| height = (height !== undefined && height !== null) ? height : 100; | |||
There was a problem hiding this comment.
Sure, these two lines do the exact same thing, but since the old one is much easier to understand, it's better. If some parentheses make code easier to read, they should stay. I don't approve of this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supply chain attack noticed in over 100,000 websites using polyfill.io.
Replaced with a safer alternative (polyfill-fastly.io)